Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add required trait impls for OpEthApi #9325

Closed
Tracked by #9294 ...
mattsse opened this issue Jul 5, 2024 · 2 comments · Fixed by #9341 or #9377
Closed
Tracked by #9294 ...

Add required trait impls for OpEthApi #9325

mattsse opened this issue Jul 5, 2024 · 2 comments · Fixed by #9341 or #9377
Labels
A-op-reth Related to Optimism and op-reth D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented Jul 5, 2024

with #9324 we now have a op type for op specific eth API

in order to reuse this type we need this type to be FullEthApi:

/// Helper trait to unify all `eth` rpc server building block traits, for simplicity.
pub trait FullEthApi:
EthApiSpec + EthTransactions + EthBlocks + EthState + EthCall + EthFees + Trace + LoadReceipt
{
}

this types needs to implement the Eth traits and all prerequisites.
this can be done incrementally, trait by trait.
at first, all traits should simply delegate to the inner type that also satisfies the trait.

@mattsse mattsse added D-good-first-issue Nice and easy! A great choice to get started A-op-reth Related to Optimism and op-reth labels Jul 5, 2024
@emhane
Copy link
Member

emhane commented Jul 5, 2024

rn this code is in https://github.com/paradigmxyz/reth/blob/main/crates/rpc/rpc/src/eth/helpers/optimism.rs, and must stay there also (i.e. be duplicate) until the type OpEthApi can be plugged in (blocked by node builder)

@shiowp
Copy link
Contributor

shiowp commented Jul 6, 2024

Working on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-op-reth Related to Optimism and op-reth D-good-first-issue Nice and easy! A great choice to get started
Projects
Archived in project
3 participants