Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve engine event variants #9671

Closed
Tracked by #8742
mattsse opened this issue Jul 20, 2024 · 0 comments
Closed
Tracked by #8742

Improve engine event variants #9671

mattsse opened this issue Jul 20, 2024 · 0 comments
Assignees
Labels
C-enhancement New feature or request

Comments

@mattsse
Copy link
Collaborator

mattsse commented Jul 20, 2024

with #9670 we have the lower level event handling in place

we can consolidate some event variants for the engineapievent type

/// Events emitted by the engine API handler.
#[derive(Debug)]
pub enum EngineApiEvent {
/// Event from the consensus engine.
// TODO(mattsse): find a more appropriate name for this variant, consider phasing it out.
BeaconConsensus(BeaconConsensusEngineEvent),
/// Bubbled from tree.
FromTree(TreeEvent),
}

and get rid of the additional TreeEvent type

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement New feature or request
Projects
Archived in project
Development

No branches or pull requests

1 participant