feat: migrate to new inspector API #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mattsse didn't you need the call/create inputs in Inspector |
|
I think we only need this for the foundry cheatcodes inspector, |
DaniPopes
reviewed
Jan 22, 2024
| @@ -15,7 +17,7 @@ pub use maybe_owned::MaybeOwnedInspector; | |||
| /// - Block: Hook on block execution | |||
| /// - BlockWithIndex: Hook on block execution transaction index | |||
| /// - Transaction: Hook on a specific transaction hash | |||
There was a problem hiding this comment.
yeah, this was the case previously, tbh I don't know why this is here.
Perhpas the idea was to move the stack from foundry to here, but I'd rather delete this one here, will probably do so.
|
Bumped to newest revm on |
|
lgtm |
DaniPopes
reviewed
Feb 5, 2024
|
will merge after CI |
mattsse
added a commit
that referenced
this pull request
Mar 6, 2024
this is a leftover of #11 @rakita the `output` of `CreateOutcome` is the runtime bytecode, right? https://github.com/paradigmxyz/evm-inspectors/blob/05352cd16db13fd89e9a974487b456e3f1498c69/src/tracing/types.rs#L48-L50
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2
Blocked by reth migration
and
bluealloy/revm#1001