Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: selfdestructs once and for all #111

Merged
merged 1 commit into from
May 7, 2024
Merged

fix: selfdestructs once and for all #111

merged 1 commit into from
May 7, 2024

Conversation

DaniPopes
Copy link
Member

In >=Cancun selfdestruct inspector function is not called, but SELFDESTRUCT is still returned as instruction result.

Found while debugging foundry-rs/foundry#7880

@DaniPopes DaniPopes requested a review from mattsse May 7, 2024 10:47
@DaniPopes
Copy link
Member Author

I realize that theres no way to get the refund address in cancun because the inspector isnt called unless im missing something

Copy link
Contributor

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

selfdestructs 👎

I realize that theres no way to get the refund address in cancun because the inspector isnt called unless im missing something

is this because selfdestructs are deprecated?

@DaniPopes
Copy link
Member Author

DaniPopes commented May 7, 2024

yes but the value transfer still happens, it's just that we can't get the target or value

@DaniPopes DaniPopes merged commit ee6f6be into main May 7, 2024
11 checks passed
@DaniPopes DaniPopes deleted the dani/selfdestruct branch May 7, 2024 12:13
@DaniPopes DaniPopes mentioned this pull request May 7, 2024
DaniPopes added a commit that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants