Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: track selfdestruct transferred value separately #153

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

mattsse
Copy link
Contributor

@mattsse mattsse commented Jun 26, 2024

in ee6f6be we updated

node.trace.value = value; with the selfdestruct value transfer.

this results in incorrect traces for original call: paradigmxyz/reth#9124

This tracks the transferred value in a separate field similar to refund address.

@mattsse mattsse requested a review from DaniPopes as a code owner June 26, 2024 17:09
Copy link
Member

@DaniPopes DaniPopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgmt

@mattsse mattsse merged commit 3bfc98c into main Jun 26, 2024
11 checks passed
@DaniPopes DaniPopes deleted the matt/track-selfdestruct-transfer-separately branch June 26, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants