fix(tracing): don't overwrite selfdestruct_address #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jsvisa <delweng@gmail.com>
Signed-off-by: jsvisa <delweng@gmail.com>
Signed-off-by: jsvisa <delweng@gmail.com>
jsvisa
force-pushed
the
selfdestruct-no-overwrite
branch
from
7af0add
to
c726ad4
Compare
lwedge99
pushed a commit
to sentioxyz/revm-inspectors
that referenced
this pull request
Oct 8, 2024
fix paradigmxyz/reth#10755 https://github.com/paradigmxyz/revm-inspectors/blob/e8a5f56a7270a404408c83b4b92977d9d013882f/src/tracing/builder/parity.rs#L234-L236 this reminds me of `selfdestruct` reuses the call's struct, so we can't rewrite the call's `address`, especially in `delegatecall` waiting for the new release of https://github.com/bluealloy/revm --------- Signed-off-by: jsvisa <delweng@gmail.com> Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix paradigmxyz/reth#10755
revm-inspectors/src/tracing/builder/parity.rs
Lines 234 to 236 in e8a5f56
this reminds me of
selfdestructreuses the call's struct, so we can't rewrite the call'saddress, especially indelegatecallwaiting for the new release of https://github.com/bluealloy/revm