Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add creation code printing in traces #202

Merged
merged 4 commits into from
Sep 23, 2024

Conversation

CodeSandwich
Copy link
Contributor

This is needed for foundry-rs/foundry#8906

Copy link
Contributor

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems fine, pending @klkvr

src/tracing/writer.rs Outdated Show resolved Hide resolved
src/tracing/writer.rs Outdated Show resolved Hide resolved
src/tracing/writer.rs Outdated Show resolved Hide resolved
tests/it/writer.rs Outdated Show resolved Hide resolved
Copy link
Member

@DaniPopes DaniPopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@DaniPopes DaniPopes merged commit 4dea8c4 into paradigmxyz:main Sep 23, 2024
11 checks passed
@CodeSandwich CodeSandwich deleted the trace_creation_code branch September 23, 2024 10:29
@CodeSandwich
Copy link
Contributor Author

It seems that I missed the 0.7.5 release by an hour 😆 Do you have a plan to release 0.7.6 that would include changes from this PR?

@mattsse
Copy link
Contributor

mattsse commented Sep 23, 2024

doing rn

lwedge99 pushed a commit to sentioxyz/revm-inspectors that referenced this pull request Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants