fix(tracing/js): error not set in result_fn #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jsvisa <delweng@gmail.com>
Signed-off-by: jsvisa <delweng@gmail.com>
Signed-off-by: jsvisa <delweng@gmail.com>
DaniPopes
reviewed
Oct 11, 2024
Signed-off-by: jsvisa <delweng@gmail.com>
Signed-off-by: jsvisa <delweng@gmail.com>
mattsse
requested changes
Oct 14, 2024
src/tracing/js/mod.rs
Outdated
Comment on lines
259
to
262
| if let TransactTo::Call(target) = env.tx.transact_to { | ||
| to = Some(target); | ||
| } | ||
| let r#type = match env.tx.transact_to { |
There was a problem hiding this comment.
oops, did we not set this properly?
There was a problem hiding this comment.
no, declare a tmp variable to make the ctx builder more compacted. And I see your point, I'll rollback the changes.
| @@ -236,6 +236,7 @@ impl JsInspector { | |||
| let gas_used = result.gas_used(); | |||
| let mut to = None; | |||
There was a problem hiding this comment.
lets remove this tmp var and do env.tx.transact_to.to().copied() instead
There was a problem hiding this comment.
I don't think so, as txkind's to address will return None for the creation tx, so also need to extract from the creation's result
https://github.com/alloy-rs/core/blob/main/crates/primitives/src/common.rs#L47-L53
Signed-off-by: jsvisa <delweng@gmail.com>
mattsse
approved these changes
Oct 15, 2024
| @@ -236,6 +236,7 @@ impl JsInspector { | |||
| let gas_used = result.gas_used(); | |||
| let mut to = None; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only set step's error, but missing the result's one.
use this tx to test it
{ "jsonrpc": "2.0", "method": "debug_traceTransaction", "id": "1", "params": [ "0x18ba7c5bcb851072612c0451377f55ac4ef83986ec8d9f87a2ce07c9a7d6371f", { "tracer": "{ fault: function() {}, result: function(ctx, _) { return { error: !!ctx.error }; } }" } ] }for geth/erigon's response is:
{ "id": "1", "jsonrpc": "2.0", "result": { "error": true } }currently reth's response is:
{ "id": "1", "jsonrpc": "2.0", "result": { "error": false } }