Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(clippy): make clippy happy #27

Merged
merged 2 commits into from
Feb 10, 2024
Merged

chore(clippy): make clippy happy #27

merged 2 commits into from
Feb 10, 2024

Conversation

mattsse
Copy link
Contributor

@mattsse mattsse commented Feb 10, 2024

rm redundant lint https://github.com/paradigmxyz/evm-inspectors/actions/runs/7855531397/job/21437338557#step:5:19

error: lint group `rust_2018_idioms` has the same priority (0) as a lint
  --> Cargo.toml:19:6
   |
18 | rust.unused_must_use = "deny"
   |      --------------- has the same priority as this lint
19 | rust.rust_2018_idioms = "deny"
   |      ^^^^^^^^^^^^^^^^   ------ has an implicit priority of 0

@mattsse
Copy link
Contributor Author

mattsse commented Feb 10, 2024

@DaniPopes have you seen this before,
no idea what lint groups are or what this error means

@DaniPopes
Copy link
Member

DaniPopes commented Feb 10, 2024

Don't know, can't even repro locally anywhere can repro in a new crate. I don't see why this would be a problem since the rust_2018_idioms group doesn't overlap with any other lint defined.

@DaniPopes
Copy link
Member

I think you can just safely ignore this with clippy.lint_groups_priority = "allow".

@DaniPopes DaniPopes merged commit b8bd5bc into main Feb 10, 2024
11 checks passed
@DaniPopes DaniPopes deleted the matt/rm-redundant-lint branch February 10, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants