Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add feature-gated Serde implementations #47

Merged
merged 1 commit into from
Feb 19, 2024
Merged

feat: add feature-gated Serde implementations #47

merged 1 commit into from
Feb 19, 2024

Conversation

DaniPopes
Copy link
Member

@DaniPopes DaniPopes marked this pull request as ready for review February 19, 2024 13:41
mattsse
mattsse approved these changes Feb 19, 2024
View reviewed changes
Copy link
Contributor

@mattsse mattsse left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

mental note that we have to enable this on reth when we bump

new clippys unlocked

@DaniPopes
Copy link
Member Author

Actually it's Rustc improving dead imports detection :D

@DaniPopes DaniPopes merged commit 5e9e1a7 into main Feb 19, 2024
10 of 11 checks passed
@DaniPopes DaniPopes deleted the dani/serde branch February 19, 2024 13:52
@DaniPopes DaniPopes mentioned this pull request Feb 19, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@onbjerg onbjerg Awaiting requested review from onbjerg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DaniPopes @mattsse