feat(tracing): implement muxTracer #57
Conversation
ArtificialPB
force-pushed
the
feat/mux-tracer
branch
from
4ab328c
to
6abd4ff
Compare
| fn selfdestruct<DB: Database>(&mut self, contract: Address, target: Address, value: U256) { | ||
| match self { | ||
| MultiInspector::FourByteInspector(inspector) => { | ||
| <FourByteInspector as Inspector<DB>>::selfdestruct( |
There was a problem hiding this comment.
I faced the same issue with the selfdestruct call but couldn't figure out why this is necessary here
There was a problem hiding this comment.
I think it's because the FourByteInspector implements the Inspector<DB> trait, where selfdestruct function has no reference to the DB type, and compiler can't infer the Inspector trait type
src/tracing/mux.rs
Outdated
|
|
||
| /// An inspector that can delegate to multiple inspector types. | ||
| #[derive(Clone, Debug)] | ||
| enum MultiInspector { |
There was a problem hiding this comment.
I think calling this multi is potentially misleading, because this only wraps a single inspector.
maybe we can find a more appropriate name?
if not I'm fine with that as well because private type
There was a problem hiding this comment.
I've renamed it to DelegatingInspector, seems like a better name
| if let Some(outcome) = inspector.call(context, inputs) { | ||
| return Some(outcome); | ||
| } |
There was a problem hiding this comment.
I believe the TracingInspector does not override the response so we can ignore this some check
There was a problem hiding this comment.
Just noticed that I forgot to add support also for the JsInspector, and that inspector overrides the outcome of create. I suggest we keep this as-is for now and add support for JsInspector via separate PR
| if let Some(outcome) = inspector.create(context, inputs) { | ||
| return Some(outcome); | ||
| } |
| .geth_call_traces(config, result.result.gas_used()) | ||
| .into(), | ||
| MultiInspector::Prestate(config, inspector) => { | ||
| inspector.into_geth_builder().geth_prestate_traces(result, config, db)?.into() |
There was a problem hiding this comment.
making a note for myself here that I need to check if we can get rid of the db argument
|
|
||
| impl MuxInspector { | ||
| /// Try creating a new instance of [MuxInspector] from the given [MuxConfig]. | ||
| pub fn try_from_config(config: MuxConfig) -> Result<MuxInspector, Error> { |
There was a problem hiding this comment.
hmm, maybe we should actually make MultiInspector pub so this type can be configured easily manually without needing MuxConfig with an additional new function
pub new(impl IntoIter<MultiInspector>) -> Self
but not required for this pr
Adds support for
muxTracer. Depends on changes from alloy-rs/alloy#252Once both PR's are good to go I'll open a PR also for
reth.