Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dep: lock alloy deps #8

Merged
merged 1 commit into from
Feb 9, 2024
Merged

dep: lock alloy deps #8

merged 1 commit into from
Feb 9, 2024

Conversation

rkrasiuk
Copy link
Member

Description

Lock alloy deps to last commit hash.

Copy link
Member

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we want this we need to lock at a similar hash in reth or the compiler will complain

we also need to update to a new commit since there have been changes in rpc types

@rkrasiuk rkrasiuk merged commit 67ab6a0 into main Feb 9, 2024
11 checks passed
@rkrasiuk rkrasiuk deleted the rkrasiuk/lock-alloy-deps branch February 9, 2024 15:40
mattsse added a commit that referenced this pull request Feb 9, 2024
mattsse added a commit that referenced this pull request Feb 9, 2024
Reverts #8

they don't need to be locked

this will be a nightmare to maintain
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants