feat: use inspector db directly in js #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
requested changes
Jan 19, 2024
src/tracing/js/bindings.rs
Outdated
| /// Creates a garbage collectible value to the given reference. | ||
| /// | ||
| /// SAFETY; the caller must ensure that the guard is dropped before the value is dropped. | ||
| pub(crate) fn r#ref(val: &Val) -> (Self, GcGuard<'_, Val>) { |
There was a problem hiding this comment.
we already have new, this calls Self::new with a ref value, the function match the enum variants
There was a problem hiding this comment.
Oh I meant new_ref instead of #ref
Co-authored-by: DaniPopes <57450786+DaniPopes@users.noreply.github.com>
DaniPopes
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6
This gets rid of the additional JS service requirement by transmuting the db reference and guarding it against garbage collection.
This applies a similar transmute hack as
std::thread::scopedby transmuting the lifetime bound of the DB via a trait object.The DB wrappers are nullable, once the guard is dropped the actual garbage collected DB reference is also removed