Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce the size of TokenKind to 8 bytes #28

Closed
DaniPopes opened this issue Jul 6, 2024 · 0 comments · Fixed by #31
Closed

Reduce the size of TokenKind to 8 bytes #28

DaniPopes opened this issue Jul 6, 2024 · 0 comments · Fixed by #31
Labels
A-parser Area: parsing source code to an AST C-perf Category: an issue highlighting optimization opportunities or PRs implementing such E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. P-low Low priority

Comments

@DaniPopes
Copy link
Member

DaniPopes commented Jul 6, 2024 •
edited
Loading

Describe the feature

By flattening TokenLit into TokenKind::Literal we can reduce the size of TokenKind (and Token) by 4 bytes.

Additional context

No response
@DaniPopes DaniPopes added C-enhancement Category: an issue proposing an enhancement or a PR with one A-parser Area: parsing source code to an AST P-low Low priority E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. labels Jul 6, 2024
@DaniPopes DaniPopes mentioned this issue Jul 6, 2024
Open
@DaniPopes DaniPopes added C-perf Category: an issue highlighting optimization opportunities or PRs implementing such and removed C-enhancement Category: an issue proposing an enhancement or a PR with one labels Jul 7, 2024
This was referenced Aug 15, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-parser Area: parsing source code to an AST C-perf Category: an issue highlighting optimization opportunities or PRs implementing such E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. P-low Low priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: implement semantic analysis paradigmxyz/solar
1 participant
@DaniPopes