Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement a builder API for Session #48

Closed
DaniPopes opened this issue Sep 21, 2024 · 0 comments · Fixed by #81
Closed

Implement a builder API for Session #48

DaniPopes opened this issue Sep 21, 2024 · 0 comments · Fixed by #81
Labels
C-enhancement Category: an issue proposing an enhancement or a PR with one E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. P-medium Medium priority S-needs-design Status: this issue requires design work to think about how it would best be accomplished

Comments

@DaniPopes
Copy link
Member

Describe the feature

We want to improve the API for usage as a library

Implement Session::builder() -> SessionBuilder that has setters for the Session fields + methods for modifying source_map and dcx

Also add Session::enter() that does interface::enter + SessionGlobals::with_source_map

Additional context

No response
@DaniPopes DaniPopes added C-enhancement Category: an issue proposing an enhancement or a PR with one S-needs-design Status: this issue requires design work to think about how it would best be accomplished P-medium Medium priority E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. labels Sep 21, 2024
@DaniPopes DaniPopes mentioned this issue Oct 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Category: an issue proposing an enhancement or a PR with one E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. P-medium Medium priority S-needs-design Status: this issue requires design work to think about how it would best be accomplished
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add Session::builder paradigmxyz/solar
1 participant
@DaniPopes