Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library does not work with 32-bit integers #38

Closed
paragonie-scott opened this issue Jul 5, 2017 · 4 comments
Closed

Library does not work with 32-bit integers #38

paragonie-scott opened this issue Jul 5, 2017 · 4 comments
Labels
Milestone

Comments

@paragonie-scott
Copy link
Member

paragonie-scott commented Jul 5, 2017

A more general issue than #37


F.F.FF..EFFEEFFFE..E....FFF.FFFF.........EFEFFFF.FF.SFF.....FS.  63 / 121 ( 52%)
.S.F.FFF.SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS      121 / 121 (100%)

Time: 27.48 seconds, Memory: 27.00MB

[snip]

ERRORS!
Tests: 121, Assertions: 674, Errors: 7, Failures: 30, Skipped: 52.

Here's the full output for the curious.
output.txt

@paragonie-scott
Copy link
Member Author

This is going to require a significant rewrite of a lot of the code, and may not be worth it.

Most systems support 64-bit integers (i.e. PHP_INT_SIZE === 8). Windows on PHP 5 is the notable exception here.

For the moment, I'm going to document this behavior and make it fail hard if PHP_INT_SIZE === 4. Adding 32-bit implementations for Windows users can come in a future release.

@paragonie-scott paragonie-scott added this to the Version 1.2.0 milestone Jul 5, 2017
@paresy
Copy link

paresy commented Jul 7, 2017

At least PHP 5.6 on Linux armhf (like Raspberry Pi) is also effected. (PHP_INT_SIZE is 4)

@paragonie-scott
Copy link
Member Author

Thanks for the update. I'll try to prioritize getting 32-bit working, but I've got a lot on my plate.

@paresy
Copy link

paresy commented Jul 11, 2017

No hurry. I think i found the bug for my PHP 7.x problem and will be able to use native support in 7.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants