Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service should not start if some components weren't built successfully #297

Closed
ionut-arm opened this issue Dec 2, 2020 · 1 comment
Closed
Labels
bug Something isn't working

Comments

@ionut-arm
Copy link
Member

Currently the service builder is silent about certain errors (i.e. by only logging a warning instead of failing to start). An example of that is attempting to start a service with a duplicate provider (e.g. using two instances of the MbedCryptoProvider). Ideally, if anything that is specified in config.toml can't be spun up exactly the way it is defined, the service should error out.

This issue is meant to cover three things:

  1. identifying where errors can happen during service building
  2. making sure that all those errors lead to the service stopping
  3. implementing a few config tests to make sure the above is implemented properly
@ionut-arm ionut-arm added the bug Something isn't working label Dec 2, 2020
@hug-dev
Copy link
Member

hug-dev commented Dec 10, 2020

Is this closed by #298 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants