Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the slot_number field optional #375

Closed
hug-dev opened this issue Mar 31, 2021 · 5 comments · Fixed by #402
Closed

Make the slot_number field optional #375

hug-dev opened this issue Mar 31, 2021 · 5 comments · Fixed by #402
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers platforms Compatibility with different secure services or hardware platforms small Effort label

Comments

@hug-dev
Copy link
Member

hug-dev commented Mar 31, 2021

The PKCS 11 provider can use the get_all_slots function to use the first slot returned if the slot_number field was not given. It will save some trouble to the admin!

@hug-dev hug-dev added enhancement New feature or request good first issue Good for newcomers platforms Compatibility with different secure services or hardware platforms small Effort label labels Mar 31, 2021
@ionut-arm
Copy link
Member

What was the difference between that one and get_slots_with_token?

@hug-dev
Copy link
Member Author

hug-dev commented Mar 31, 2021

oh yeah I think get_slots_with_token should be used.
From the documentation:

tokenPresent indicates whether the list obtained includes only those slots with a token present

I am not fully sure of the difference between a slot and a token but I think a token is in a slot when there is actually something to use there.

@Sven-bg
Copy link
Contributor

Sven-bg commented Apr 8, 2021

Hi @hug-dev, if you want I can work on it.
Thank you

@hug-dev
Copy link
Member Author

hug-dev commented Apr 8, 2021

Sure! Thank you!

@wiktor-k
Copy link

I am not fully sure of the difference between a slot and a token but I think a token is in a slot when there is actually something to use there.

Indeed. My understanding is that slot = smartcard reader, token = smartcard in the reader. For general use get_slots_with_token is better. get_all_slots is useful only when learning about the actual readers (they have some metadata associated too).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers platforms Compatibility with different secure services or hardware platforms small Effort label
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants