Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert Key ID Manager String errors to ResponseStatus in the KIM itself #77

Closed
hug-dev opened this issue Dec 13, 2019 · 0 comments · Fixed by #101
Closed

Convert Key ID Manager String errors to ResponseStatus in the KIM itself #77

hug-dev opened this issue Dec 13, 2019 · 0 comments · Fixed by #101
Labels
enhancement New feature or request

Comments

@hug-dev
Copy link
Member

hug-dev commented Dec 13, 2019

In all of our providers we check the result of the KIM trait methods and convert the String to a ResponseStatus, most of the time to be ResponseStatus::KeyIDManagerError.
To avoid this repetion of code, this could be done on the trait itself and re-used everywhere.
@hug-dev hug-dev added the enhancement New feature or request label Dec 13, 2019
@hug-dev hug-dev mentioned this issue Dec 13, 2019
Merged
@hug-dev hug-dev mentioned this issue Feb 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Review ResponseStatus usage hug-dev/parsec
1 participant
@hug-dev