Skip to content

Commit 65dd504

Browse files
using redirectUri returned by torii
1 parent d668ae8 commit 65dd504

File tree

2 files changed

+5
-10
lines changed

2 files changed

+5
-10
lines changed

flask_app/auth.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -53,14 +53,15 @@ def login():
5353

5454
auth_code = credentials.get('authorizationCode')
5555
provider = credentials.get("provider")
56+
redirect_uri = credentials.get("redirectUri")
5657

5758
_logger.info('AuthorizationCode recieved: {}', credentials)
5859

5960
if provider == "google-oauth2":
6061
return _login_with_google_oauth2(auth_code)
6162

6263
if provider == "azure-ad2-oauth2":
63-
return _login_with_azure_oauth2(auth_code)
64+
return _login_with_azure_oauth2(auth_code, redirect_uri)
6465

6566
error_abort('No credentials were specified', code=requests.codes.unauthorized)
6667

@@ -144,9 +145,9 @@ def _login_with_google_oauth2(auth_code):
144145

145146
return _make_success_login_response(user, user_info)
146147

147-
def _login_with_azure_oauth2(auth_code):
148+
def _login_with_azure_oauth2(auth_code, redirect_uri):
148149
"""Logs in with azure oath2"""
149-
user_info = get_oauth2_identity_azure(auth_code)
150+
user_info = get_oauth2_identity_azure(auth_code, redirect_uri)
150151
if not user_info:
151152
error_abort('Could not complete OAuth2 exchange', code=requests.codes.unauthorized)
152153

flask_app/utils/oauth2.py

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ def get_oauth2_identity(auth_code):
4444
_logger.debug('Found user info: {}', info)
4545
return info
4646

47-
def get_oauth2_identity_azure(auth_code):
47+
def get_oauth2_identity_azure(auth_code, redirect_uri):
4848
"""Gets identity from azure auth_code"""
4949

5050
config_dict = config.get_runtime_config_private_dict()
@@ -60,14 +60,8 @@ def get_oauth2_identity_azure(auth_code):
6060
_logger.error('No OAuth2 client secret configured')
6161
return
6262

63-
redirect_uri = request.host_url[:-1]
64-
6563
_logger.info('get_oauth2_identity: Using redirect URI {!r}', redirect_uri)
6664

67-
_logger.info("Redirect URI from the environment: {}", os.environ.get("REDIRECT_URI"))
68-
69-
redirect_uri = os.environ.get("REDIRECT_URI", redirect_uri)
70-
7165
client = msal.ConfidentialClientApplication(
7266
client_id, authority=authority,
7367
client_credential=client_secret, token_cache=None)

0 commit comments

Comments
 (0)