fix search width #1413
fix search width #1413
Conversation
Sebastian-ubs
force-pushed
the
1405-SearchBar-layout-is-broken
branch
from
a93e505 to
8556eec
Compare
Sebastian-ubs
force-pushed
the
1405-SearchBar-layout-is-broken
branch
from
e567abb to
9363bdc
Compare
There was a problem hiding this comment.
Reviewed 10 of 10 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Sebastian-ubs)
lib/platform-bible-react/src/components/advanced/tab-navigation-content-search.component.tsx line 30 at r1 (raw file):
/** Optional className to modify the search input */ searchClassName?: string;
Shouldn't this just be className?
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @rolfheij-sil)
lib/platform-bible-react/src/components/advanced/tab-navigation-content-search.component.tsx line 30 at r1 (raw file):
Previously, rolfheij-sil (Rolf Heij) wrote…
Shouldn't this just be
className?
well, my thought was to indicate where the className would be applied. Thanks for reviewing.
There was a problem hiding this comment.
Reviewable status:
complete! all files reviewed, all discussions resolved
Fixes the search bar
This is a breaking change for (potential) extensions that use
TabNavigationContentSearchtogether with the optionalisSearchBarfullWidthparameter as this was removed in favor of the more flexiblesearchClassName.I'm not aware of extensions that use TabNavigationContentSearch .
Before
After
This change is