Update tests based on latest testdata changes #2520
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kakkoyun
requested changes
Feb 19, 2024
There was a problem hiding this comment.
Hey, thanks for handling this!
Just a heads up, we need to tidy up a few things.
Also, I'm thinking it's better to use runtime.GOARCH wherever an arch is mentioned. That's unless we're aiming for a specific arch. If that's the plan, let's ensure the binary won't run on the wrong machine architecture.
Sylfrena
force-pushed
the
update-testdata-syl
branch
from
fb27b6c
to
df28890
Compare
kakkoyun
reviewed
Feb 22, 2024
Sylfrena
force-pushed
the
update-testdata-syl
branch
from
df28890
to
be7939e
Compare
Signed-off-by: Sumera Priyadarsini <sylphrenadin@gmail.com> Update unwind table tests to match latest testdata changes Signed-off-by: Sumera Priyadarsini <sylphrenadin@gmail.com>
Sylfrena
force-pushed
the
update-testdata-syl
branch
from
be7939e
to
608cd0a
Compare
|
Outdated since #2958 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2420