Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove usage of deprecated APIs #294

Closed
kakkoyun opened this issue Mar 18, 2022 · 7 comments · Fixed by #329
Closed

Remove usage of deprecated APIs #294

kakkoyun opened this issue Mar 18, 2022 · 7 comments · Fixed by #329
Assignees
@v-thakkar
Labels
area/eBPF Something involving eBPF help wanted Extra attention is needed
Milestone
v0.12.0

Comments

@kakkoyun
Copy link
Member 

libbpf: map 'counts' (legacy): legacy map definitions are deprecated, use BTF-defined maps instead
libbpf: map 'stack_traces' (legacy): legacy map definitions are deprecated, use BTF-defined maps instead
libbpf: Use of BPF_ANNOTATE_KV_PAIR is deprecated, use BTF-defined maps in .maps section instead
@kakkoyun kakkoyun added area/eBPF Something involving eBPF help wanted Extra attention is needed labels Mar 18, 2022
@kakkoyun
Copy link
Member Author

kakkoyun commented Apr 5, 2022

Requires kubernetes/minikube#12707 for testing (BTF is needed)

@v-thakkar
Copy link
Contributor

If nobody is working on this, I can take this issue.

@kakkoyun
Copy link
Member Author

kakkoyun commented Apr 5, 2022

Thanks @v-thakkar, that'd be great, actually!

@v-thakkar v-thakkar mentioned this issue Apr 7, 2022
Merged
@lilic
Copy link

lilic commented Jul 24, 2022

@kakkoyun @v-thakkar Hi I am seeing this in the latest parca-agent, was this not maybe in release v0.9.0 of the agent?


libbpf: map 'stack_traces' (legacy): legacy map definitions are deprecated, use BTF-defined maps instead
libbpf: map 'counts' (legacy): legacy map definitions are deprecated, use BTF-defined maps instead

@v-thakkar v-thakkar reopened this Jul 24, 2022
@v-thakkar
Copy link
Contributor

Aya doesn't have the proper BTF support yet for their eBPF part. So we moved to use legacy map definitions since we started using Aya for our eBPF code. Reopening this so that we remember to fix it once BTF support is there is Aya. :)

@v-thakkar
Copy link
Contributor

aya-rs/aya#351

@kakkoyun kakkoyun added this to the v0.11.0 milestone Aug 2, 2022
@maxbrunet maxbrunet mentioned this issue Sep 23, 2022
Closed
@kakkoyun
Copy link
Member Author

kakkoyun commented Oct 5, 2022

Deprecated after #869

@kakkoyun kakkoyun closed this as completed Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@v-thakkar v-thakkar

Labels
area/eBPF Something involving eBPF help wanted Extra attention is needed
Projects
None yet
Milestone
v0.12.0
Development

Successfully merging a pull request may close this issue.

eBPF: Remove the use of deprecated bpf_map_def v-thakkar/parca-agent
3 participants
@kakkoyun @lilic @v-thakkar