Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Regression] --no-minify not working on pug since 1.12.x #2890

Closed
DFOXpro opened this issue Apr 4, 2019 · 2 comments
Closed

[Regression] --no-minify not working on pug since 1.12.x #2890

DFOXpro opened this issue Apr 4, 2019 · 2 comments
Labels
🐛 Bug

Comments

@DFOXpro
Copy link

DFOXpro commented Apr 4, 2019

🐛 bug report

🎛 Configuration (.babelrc, package.json, cli command)

rm ./www -Rv; parcel build --out-dir www --no-minify src/index.pug

🤔 Expected Behavior

Rendered html pages should be pretifier / indented

😯 Current Behavior

Rendered html pages are minimized

💁 Possible Solution

Maybe related to #2887

🔦 Context

With this regression there is no way to build a dev / debug compiled version of our projects.
note included code is not minimized.

💻 Code Sample

Input

html
	head
		title
	body
		div#app
		script
			include ./index.js

Output

<html><head><title></title></head><body><div id="app"></div><script>var app = new Vue({
  el: '#app',
  data: {
    name: 'mundo',
    link: {
      url: 'http://asd.com',
      name: 'asd.com',
      show: true
    }
  }
});</script></body></html>

🌍 Your Environment

Software Version(s)
Parcel 1.12.0 ~ .3
Node v10.15.3
npm/Yarn 6.9.0
Operating System Xbuntu 18.04.2
@ciaranashton
Copy link

Not sure if this is bug. I found this #2582 PR which removes this ability due to Pug deprecating the pretty option. Pug API

@mischnic
Copy link
Member

mischnic commented Apr 8, 2019

Good catch.
@DFOXpro If you really want pretty output, you should be able to set the pretty option in the pug option file:

// pug.config.js

module.exports = {
  pretty: true
};

@mischnic mischnic closed this as completed Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mischnic @DFOXpro @ciaranashton