Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Cannot resolve dependency for itms-apps://... #437

Closed
hkwid opened this issue Dec 29, 2017 · 1 comment
Closed

🐛 Cannot resolve dependency for itms-apps://... #437

hkwid opened this issue Dec 29, 2017 · 1 comment

Comments

@hkwid
Copy link

hkwid commented Dec 29, 2017

When I tried to use the app store link like itms-apps://itunes.apple.com/en/app/awesomeApp/id1234567890 as href attr.
Get Cannot resolve dependency error.

<!-- index.html -->
...
<a href="itms-apps://itunes.apple.com/en/app/awesomeApp/id1234567890">App Store Link</a>
...

🎛 Configuration

$ parcel src/index.html

🤔 Expected Behavior

When the URI schema is valid, it should not try to resolve the dependency.

😯 Current Behavior

Even the URI schema is valid, it tries to resolve the dependency.
The error log is like below

/path/to/the/project/src/index.html: Cannot resolve dependency './itms-apps:/itunes.apple.com/en/app/awesomeApp/id1234567890' at '/path/to/the/project/src/itms-apps:/itunes.apple.com/en/app/awesomeApp/id1234567890'
at /path/to/the/project/node_modules/browser-resolve/node_modules/resolve/lib/async.js:55:21
at load (/path/to/the/project/node_modules/browser-resolve/node_modules/resolve/lib/async.js:69:43)
at onex (/path/to/the/project/node_modules/browser-resolve/node_modules/resolve/lib/async.js:92:31)
at /path/to/the/project/node_modules/browser-resolve/node_modules/resolve/lib/async.js:22:47
at FSReqWrap.oncomplete (fs.js:152:21)

💁 Possible Solution

According to wiki https://en.wikipedia.org/wiki/Uniform_Resource_Identifier#Syntax, URI schema can include ., -, + ... etc.

Maybe tweak SCHEME_REGEXP in src/utils/is-url.js to cover such a schemas.

@devongovett
Copy link
Member

Should be fixed by #438 which will be in a release shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants