Fix the instantiate command for Substrate 0.9.42-based chains #1564
Conversation
smiasojed
changed the title
| @@ -78,21 +78,15 @@ pub struct ContractResult<R, Balance, EventRecord> { | |||
| pub debug_message: Vec<u8>, | |||
| /// The execution result of the wasm code. | |||
| pub result: R, | |||
| /// The events that were emitted during execution. It is an option as event | |||
| /// collection is optional. | |||
| pub events: Option<Vec<EventRecord>>, | |||
There was a problem hiding this comment.
What about chains that still have the events field?
There was a problem hiding this comment.
we do not use it in our code, so it is just not decoded from binary data.
There was a problem hiding this comment.
Where do the events depicted after calling/instantiating/etc. come from if not the ContractResult?
There was a problem hiding this comment.
They are read from the block, please take a look at subxt function:
wait_for_success https://github.com/paritytech/subxt/blob/a0cb14aa4f5e60c9c88d7adea08a7dd6f0a6a22e/subxt/src/tx/tx_progress.rs#L264
CHANGELOG.md
Outdated
| @@ -6,6 +6,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
|
|
|||
| ## [Unreleased] | |||
|
|
|||
| ### Added | |||
| - Add `cargo contract storage --version` command - [#1546](https://github.com/paritytech/cargo-contract/pull/1564) | |||
There was a problem hiding this comment.
There is already an Added section :).
CHANGELOG.md
Outdated
| @@ -6,7 +6,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
|
|
|||
| ## [Unreleased] | |||
|
|
|||
| ### Fixed | |||
| - Fix the `instantiate` command for Substrate `0.9.42` based chains - [#1546](https://github.com/paritytech/cargo-contract/pull/1564) | |||
There was a problem hiding this comment.
| - Fix the `instantiate` command for Substrate `0.9.42` based chains - [#1546](https://github.com/paritytech/cargo-contract/pull/1564) | |
| - Fix the `instantiate` command for Substrate `0.9.42` based chains - [#1564](https://github.com/paritytech/cargo-contract/pull/1564) |
| ); | ||
| if self.version { | ||
| println!("{}", storage_layout.version().await?); | ||
| Ok(()) |
There was a problem hiding this comment.
Please return early here to save us from the else indentation.
Co-authored-by: Michael Müller <michi@parity.io>
Co-authored-by: Michael Müller <michi@parity.io>
Co-authored-by: Michael Müller <michi@parity.io>
Summary
Closes #1563
inkorpallet-contracts?Description
Fix instantiate command
Add
cargo contract storage --versioncommandChecklist before requesting a review
CHANGELOG.md