Replace log/env_logger with tracing/tracing_subscriber #689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
athei
approved these changes
Aug 12, 2022
Merged
HCastano
added a commit
that referenced
this pull request
Aug 16, 2022
* Add `WasmOptHandler` Just a basic copy-pasta of what's in the existing optimization code * Move code from `optimize_wasm` into a handler method * Pull suggestion string into const * Remove old Wasm optimization functions * Remove `dest_optimized` argument from `optimize` method * Move `check_wasm_opt_version_compatibility` into WasmOptHandler impl I think it makes sense to have this be associated with the handler instead of just floating around on its own. * Move the handler code further up the module, before all the functions * Decrease indentation of error string * Move `WasmOptHandler` into its own module * Move `create_executable` test helper to `utils` module * Switch from `env_logger` to `tracing` Related PR: #689 * Indent some code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since main dependencies e.g.
subxtandjsonrpseeare usingtracing, we should use these in order to see the logging output from those libraries.