Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix numbering of steps during build #715

Merged
merged 1 commit into from
Aug 30, 2022
Merged

Fix numbering of steps during build #715

merged 1 commit into from
Aug 30, 2022

Conversation

SkymanOne
Copy link
Contributor

The solution simply bumps the number of steps in the build workflow.

The result for build with all flag:

cargo contract build --skip-linting --generate all
 [1/6] Skip ink! linting rules
 [2/6] Building cargo project
    Updating crates.io index
    Finished release [optimized] target(s) in 0.26s
 [3/6] Post processing wasm file
 [4/6] Optimizing wasm file
 [5/6] Generating metadata
    Updating crates.io index
   Compiling metadata-gen v0.1.0 (/private/var/folders/4v/n3610fp154z5qxgdqf8nnpj80000gn/T/cargo-contract_dxoOs4/.ink/metadata_gen)
    Finished release [optimized] target(s) in 0.79s
     Running `target/ink/release/metadata-gen '' `
 [6/6] Generating bundle
...

The result for build with code-only flag:

cargo contract build --skip-linting --generate code-only
 [1/4] Skip ink! linting rules
 [2/4] Building cargo project
    Updating crates.io index
    Finished release [optimized] target(s) in 1.36s
 [3/4] Post processing wasm file
 [4/4] Optimizing wasm file

Original wasm size: 47.5K, Optimized: 22.0K

The contract was built in DEBUG mode.

Your contract's code is ready. You can find it here:
...

@cla-bot-2021
Copy link

cla-bot-2021 bot commented Aug 30, 2022

User @SkymanOne, please sign the CLA here.

@SkymanOne SkymanOne changed the title updating the number of steps Fix Numbering of steps is incorrect Aug 30, 2022
@SkymanOne
Copy link
Contributor Author

SkymanOne commented Aug 30, 2022

Resolves #592

Copy link
Contributor

@HCastano HCastano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@HCastano HCastano changed the title Fix Numbering of steps is incorrect Fix numbering of steps during build Aug 30, 2022
@HCastano HCastano merged commit 990b3ec into use-ink:master Aug 30, 2022
@SkymanOne SkymanOne deleted the fixing-steps branch August 30, 2022 21:52
@cmichi
Copy link
Collaborator

cmichi commented Aug 31, 2022

Thank you!

No biggie for this, but as a sidenote: Generally it's good to already make an entry for user facing changes in the [Unreleased] section of https://github.com/paritytech/cargo-contract/blob/master/CHANGELOG.md together with the PR. Then we don't overlook things for the next release.

@athei athei mentioned this pull request Sep 2, 2022
@ascjones ascjones mentioned this pull request Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants