Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix command bot bench-all pallet --pallet= when runtime does not provide requested pallet #68

Open
bkontur opened this issue Mar 12, 2024 · 0 comments

Comments

@bkontur
Copy link
Contributor

bkontur commented Mar 12, 2024

I think it should be possible to fix it, because we have command to list all pallets for runtime:

pallets=($(
  ./target/production/polkadot benchmark pallet --list \
    --chain=./$CHAIN-chain-spec.json |
    tail -n+2 |
    cut -d',' -f1 |
    sort |
    uniq
));

so when runtime does not support a requested pallet, it should just skip and do not fail like this https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5504933 or https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5504934

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant