Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Consensus hook should be feature-flagged #2905

Closed
rphmeier opened this issue Jul 19, 2023 · 1 comment
Closed

Consensus hook should be feature-flagged #2905

rphmeier opened this issue Jul 19, 2023 · 1 comment
Labels
I7-refactor Code needs refactoring.

Comments

@rphmeier
Copy link
Contributor

rphmeier commented Jul 19, 2023

The new ParachainSystem::ConsensusHook type parameter should be feature-flagged. The actual logic of the consensus hook doesn't need to be (as it's backwards compatible), but adding the type to the trait itself is a breaking change. If the feature flag is disabled, the logic should run with ExpectParentIncluded (and later, RequireParentIncluded)

@rphmeier rphmeier added the I7-refactor Code needs refactoring. label Jul 19, 2023
@BradleyOlson64
Copy link
Contributor

Closed by #2911

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
I7-refactor Code needs refactoring.
Projects
None yet
Development

No branches or pull requests

2 participants