Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

benchmark_metadata missing for polkadot-v0.9.10 #637

Closed
NachoPal opened this issue Oct 1, 2021 · 8 comments
Closed

benchmark_metadata missing for polkadot-v0.9.10 #637

NachoPal opened this issue Oct 1, 2021 · 8 comments

Comments

@NachoPal
Copy link
Contributor

NachoPal commented Oct 1, 2021

Can not build with --features runtime-benchmarks for polkadot-v0.9.10 because missing benchmark_metadata

Related to: #589

@bkchr
Copy link
Member

bkchr commented Oct 1, 2021

@bkchr
Copy link
Member

bkchr commented Oct 1, 2021

polkadot-v0.9.10 branch is the "cumulus release", not statemine/statemint

@NachoPal
Copy link
Contributor Author

NachoPal commented Oct 1, 2021

Yes, I know. I found that accidentally comparing benchmarks implementations between branches. I know I don't need that fixed for the Statemint release. Actually in release-statemine-v4, benchmark_metadata is not missing.

@bkchr
Copy link
Member

bkchr commented Oct 1, 2021

So this is fixed?

@bkchr bkchr closed this as completed Oct 1, 2021
@NachoPal
Copy link
Contributor Author

NachoPal commented Oct 1, 2021

It is not, giving a heads up. Not sure if there was some reason for not having it.

@bkchr
Copy link
Member

bkchr commented Oct 1, 2021

You mean this error now: #588 ?

@NachoPal
Copy link
Contributor Author

NachoPal commented Oct 1, 2021

No, I meant the initial issue of this thread:

Can not build with --features runtime-benchmarks for polkadot-v0.9.10 because missing benchmark_metadata

@bkchr
Copy link
Member

bkchr commented Oct 1, 2021

Yeah the point being that this is a branch for parachain developers and should not be used for anything statemine related.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants