Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Github Actions #35

Closed
weezy20 opened this issue Jun 22, 2023 · 3 comments · Fixed by #36
Closed

Improve Github Actions #35

weezy20 opened this issue Jun 22, 2023 · 3 comments · Fixed by #36

Comments

@weezy20
Copy link
Contributor

weezy20 commented Jun 22, 2023

Problem: We are running out of disk space by the time the GH actions reaches the Ensure Benchmarking Compiles step. This is annoying as we have limited disk space and running each step without caching build artifacts can take up too much time.

PR #34

@weezy20
Copy link
Contributor Author

weezy20 commented Jun 22, 2023

We can also remove env : NIGHTLY entirely as according to this PR, substrate compiles with stable rust > 1.68

@stiiifff
Copy link
Contributor

@weezy20 Is this closed by #34

@weezy20
Copy link
Contributor Author

weezy20 commented Jun 23, 2023

@stiiifff As mentioned in the #34, while this does make the CI pass, it's not the best solution considering that we don't make use of caching. I'd prefer to keep this issue open while we investigate how to introduce caching of dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants