Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Memory #1137

Merged
merged 1 commit into from
Feb 17, 2022
Merged

Remove Memory #1137

merged 1 commit into from
Feb 17, 2022

Conversation

cmichi
Copy link
Collaborator

@cmichi cmichi commented Feb 17, 2022

Removing it for now, mostly since we're not completely sure about the implications it now has with the changes we made to ink_storage, e.g. how it behaves if somebody gets the idea of putting Mapping in there.

@codecov-commenter
Copy link

codecov-commenter commented Feb 17, 2022

Codecov Report

Merging #1137 (403e13c) into master (e345679) will decrease coverage by 0.49%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1137      +/-   ##
==========================================
- Coverage   78.66%   78.16%   -0.50%     
==========================================
  Files         253      252       -1     
  Lines        9411     9386      -25     
==========================================
- Hits         7403     7337      -66     
- Misses       2008     2049      +41     
Impacted Files Coverage Δ
crates/primitives/src/key_ptr.rs 75.00% <0.00%> (-25.00%) ⬇️
crates/engine/src/test_api.rs 73.80% <0.00%> (-20.24%) ⬇️
...tes/env/src/engine/experimental_off_chain/impls.rs 41.66% <0.00%> (-12.04%) ⬇️
crates/engine/src/ext.rs 65.27% <0.00%> (-6.95%) ⬇️
...ates/storage/src/collections/hashmap/fuzz_tests.rs 96.80% <0.00%> (+1.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e345679...403e13c. Read the comment docs.

@paritytech-cicd-pr
Copy link

🦑 📈 ink! Example Contracts ‒ Changes Report 📉 🦑

These are the results when building the examples/* contracts from this branch with cargo-contract 0.17.0-4195197 and comparing them to ink! master:

Δ Optimized Size Δ Used Gas Total Optimized Size Total Used Gas
accumulator 1.35 K
adder 2.47 K
contract-terminate 1.23 K 215_704
contract-transfer 8.47 K 15_704
delegator 6.86 K 50_833
dns 9.70 K 47_112
erc1155 28.12 K 94_224
erc20 9.34 K 47_112
erc721 13.17 K 125_632
flipper 1.63 K 15_704
incrementer 1.56 K 15_704
multisig 26.25 K 102_922
proxy 3.36 K 32_147
rand-extension 4.64 K 15_704
subber 2.48 K
trait-erc20 9.64 K 47_112
trait-flipper 1.41 K 15_704
trait-incrementer 1.54 K 31_408

Link to the run | Last update: Thu Feb 17 20:04:58 CET 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants