Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make more functions be const #1574

Merged
merged 5 commits into from
Jan 11, 2023
Merged

Conversation

yjhmelody
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2023

Codecov Report

Merging #1574 (28cd24d) into master (8c5ee37) will decrease coverage by 0.08%.
The diff coverage is 71.42%.

@@            Coverage Diff             @@
##           master    #1574      +/-   ##
==========================================
- Coverage   71.61%   71.52%   -0.09%     
==========================================
  Files         205      205              
  Lines        6298     6290       -8     
==========================================
- Hits         4510     4499      -11     
- Misses       1788     1791       +3     
Impacted Files Coverage Δ
crates/env/src/call/call_builder.rs 0.00% <ø> (ø)
crates/ink/src/env_access.rs 9.09% <ø> (ø)
crates/primitives/src/types.rs 20.00% <0.00%> (-13.34%) ⬇️
crates/env/src/engine/off_chain/impls.rs 47.64% <100.00%> (ø)
crates/storage/src/lazy/mapping.rs 66.66% <100.00%> (-1.52%) ⬇️
crates/storage/src/lazy/mod.rs 71.42% <100.00%> (-1.30%) ⬇️
crates/allocator/src/bump.rs 86.55% <0.00%> (-2.71%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@ascjones ascjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Next time please include a description for the PR, even if relatively simple.

@ascjones ascjones merged commit a4443c1 into use-ink:master Jan 11, 2023
@yjhmelody yjhmelody deleted the more-const branch January 12, 2023 04:28
@ascjones ascjones mentioned this pull request Jan 12, 2023
HCastano pushed a commit that referenced this pull request Jan 23, 2023
* feat: make more functions be const

* fix

* fix

* fix examples

* fmt
@HCastano HCastano mentioned this pull request Jan 24, 2023
@ascjones ascjones mentioned this pull request Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants