Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename _checked codegen call methods with try_ #1621

Merged
merged 5 commits into from
Jan 26, 2023
Merged

Rename _checked codegen call methods with try_ #1621

merged 5 commits into from
Jan 26, 2023

Conversation

HCastano
Copy link
Contributor

This PR changes the name of the generated ContractRef message methods from _checked
to try_.

This is meant to keep things consistent with the CallBuilder API which uses the try_
prefix for methods which return errors.

Addresses this comment.

@HCastano HCastano requested a review from athei January 26, 2023 01:30
@HCastano HCastano merged commit 858684d into master Jan 26, 2023
@HCastano HCastano deleted the hc-rename-checked-codegen-methods branch January 26, 2023 04:10
@ascjones ascjones mentioned this pull request Feb 1, 2023
Merged
@ascjones ascjones mentioned this pull request Feb 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@athei athei athei approved these changes

@cmichi cmichi Awaiting requested review from cmichi cmichi is a code owner

@ascjones ascjones Awaiting requested review from ascjones ascjones is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HCastano @athei