-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow setting block time for off-chain testing #1721
Allow setting block time for off-chain testing #1721
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR is already pretty good, just some nits.
Could you also update the file CHANGELOG.md
? There is an [Unreleased]
section and you can add it under a ## Added
heading there.
Co-authored-by: Michael Müller <mich@elmueller.net>
Co-authored-by: Michael Müller <mich@elmueller.net>
…//github.com/CrommVardek/ink into vardek-env-offchain-test-set-block-timestamp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @CrommVardek !
Hope to see more PR's of you :-).
Adding a
Engine::set_block_timestamp
function to solve issue #1713Added a test accordingly.