Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting block time for off-chain testing #1721

Merged

Conversation

CrommVardek
Copy link
Contributor

Adding a Engine::set_block_timestamp function to solve issue #1713

Added a test accordingly.

Copy link
Collaborator

@cmichi cmichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR is already pretty good, just some nits.

Could you also update the file CHANGELOG.md? There is an [Unreleased] section and you can add it under a ## Added heading there.

Copy link
Collaborator

@cmichi cmichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @CrommVardek !

Hope to see more PR's of you :-).

@cmichi cmichi merged commit 227085b into use-ink:master Mar 23, 2023
@SkymanOne SkymanOne mentioned this pull request Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants