Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist buffer size in the metadata #1880

Merged
merged 4 commits into from
Aug 18, 2023
Merged

Conversation

SkymanOne
Copy link
Contributor

@SkymanOne SkymanOne commented Aug 18, 2023

Feat to #1869 and closes #1879

Adds "staticBufferSize" field to the metadata file:

Example:

      "maxEventTopics": 4,
      "staticBufferSize": 16384,
      "timestamp": {
        "displayName": [
          "Timestamp"
        ],
        "type": 11
      }

@codecov-commenter
Copy link

Codecov Report

Merging #1880 (7f012ed) into master (01f1cc6) will increase coverage by 0.04%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master    #1880      +/-   ##
==========================================
+ Coverage   53.00%   53.04%   +0.04%     
==========================================
  Files         212      212              
  Lines        6739     6745       +6     
==========================================
+ Hits         3572     3578       +6     
  Misses       3167     3167              
Files Changed Coverage Δ
crates/ink/codegen/src/generator/metadata.rs 0.00% <0.00%> (ø)
crates/metadata/src/tests.rs 100.00% <ø> (ø)
crates/metadata/src/specs.rs 96.94% <100.00%> (+0.03%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@SkymanOne SkymanOne merged commit e52c31a into master Aug 18, 2023
@SkymanOne SkymanOne deleted the gn/buffer-size-in-metadata branch August 18, 2023 14:51
@SkymanOne SkymanOne mentioned this pull request Feb 26, 2024
5 tasks
@SkymanOne SkymanOne mentioned this pull request Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Persist static buffer size in the metadata
3 participants