Drink backend: allow for arbitrary runtime #1892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmikolajczyk41
requested review from
cmichi,
ascjones and
SkymanOne
as code owners
SkymanOne
approved these changes
Sep 7, 2023
| @@ -73,5 +73,22 @@ pub mod flipper { | |||
|
|
|||
| Ok(()) | |||
| } | |||
|
|
|||
| /// Just instantiate a contract using non-default runtime. | |||
| #[ink_e2e::test(backend = "runtime-only", runtime = drink::runtime::MinimalRuntime)] | |||
There was a problem hiding this comment.
Can't you do?
Suggested change
| #[ink_e2e::test(backend = "runtime-only", runtime = drink::runtime::MinimalRuntime)] | |
| #[ink_e2e::test(backend = "runtime-only", runtime = ::ink_e2e::MinimalRuntime)] |
There was a problem hiding this comment.
oh sure, that's why I reexported it (but somehow I forgot about it here...); fixed
…time # Conflicts: # crates/ink/tests/ui/contract/fail/message-returns-non-codec.stderr # crates/ink/tests/ui/trait_def/fail/message_output_non_codec.stderr
ascjones
approved these changes
Sep 7, 2023
crates/e2e/src/drink_client.rs
Outdated
| @@ -221,10 +227,12 @@ impl< | |||
| } | |||
| }; | |||
|
|
|||
| let code_hash_raw: [u8; 32] = result.code_hash.as_ref().try_into().expect(""); | |||
There was a problem hiding this comment.
Empty string in expect("")
There was a problem hiding this comment.
must have missed it; fixed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
drink_client::Clientgeneric over runtime and allow choosing runtime in the e2e test macro.