Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cargo-contract
orpallet-contracts
?Description
Instead of parsing e2e configuration arguments, checking for errors and handling all situations manually, we can use
darling
library that is dedicated for exactly such boilerplate.I have removed most of the testcases (leaving only the positive scenario) - they seem to be completely unnecessary now, since all the error detection and handling is now outsourced. We may however bring them back (preferably in another PR) as UI tests for e2e crate.
The only breaking change is that we won't accept
runtime-only
literal (onlyruntime_only
is now valid). Additionally, we accept path arguments (likeruntime
) both in raw form and as literals (default indarling
).Note: we had to change
additional_contracts
field type fromVec<String>
toString
, sincedarling
doesn't support parsingVec<String>
in the intended way (only by multiple argument occurrences). However, this is not visible from outside struct internal implementation.Checklist before requesting a review
CHANGELOG.md