-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose direct configuration of max in and out buffer capacity #594
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, let's add a test?
@niklasad1, @maciejhirsz, @dvdplm - added some basic tests. I originally was going to assert every config value, but I could not think of a zero overhead way around the fact some of the more complex types don't support equality comparisons. It also looks like those complex types are tested implicitly in some of the higher level tests so I think that means technically they are covered. Unrelated to the tests, I realized this PR may break the API since it changes the defaults for |
IMO, the tests are sufficient for this change
Ok, because If we want to go with 10MB instead would it be reasonable to use it for However, I'm not familiar with the reasoning about these limits but 5MB should cover most use-cases AFAIK but perhaps @maciejhirsz or @tomusdrw could explain the reasoning about these limits :) |
I can't remember exactly, but wasn't this the same limit as |
For the record, the default 10mb limit in |
Just need one more approval :) |
@dvdplm: can you take a look at this again? |
Closes #590, see issue for feature description.
If not set,
max_in_buffer_capacity
andmax_out_buffer_capacity
explicitly defaults to 10,485,760, which is the same asparity-ws
Settings::default
.