You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Not that I need this feature at all but reading the code makes me think the notification feature implementation isn't really correct.
Firstly, notifications are completely ignored (if handled). I don't see any interface exposed by jsonrpsee to allow subscription of notifications.
Secondly, the websocket server handles notifications inconsistently. For batch request, it will parse notifications and suppress responses. However, for single request, it simply error out with parse error, which I don't think is not spec confirming.
The text was updated successfully, but these errors were encountered:
Firstly, notifications are completely ignored (if handled). I don't see any interface exposed by jsonrpsee to allow subscription of notifications.
For the server, that is correct jsonrpsee only support ethereum pubsub which is similar.
We opened an issue for that a while ago but no interest so we decided to close it.
Secondly, the websocket server handles notifications inconsistently. For batch request, it will parse notifications and suppress responses. However, for single request, it simply error out with parse error, which I don't think is not spec confirming.
That's is not correct.
For JSON-RPC notifications:
HTTP server: just ACK the notification by send HTTP status code 200
WS server: just ignore
Batch response: notifications are ignored and only calls are processed
Ok, I see I introduced a bug when I did some refactoring for the WS stuff.
Not that I need this feature at all but reading the code makes me think the notification feature implementation isn't really correct.
Firstly, notifications are completely ignored (if handled). I don't see any interface exposed by jsonrpsee to allow subscription of notifications.
Secondly, the websocket server handles notifications inconsistently. For batch request, it will parse notifications and suppress responses. However, for single request, it simply error out with parse error, which I don't think is not spec confirming.
The text was updated successfully, but these errors were encountered: