Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Number of permits exceeds limit on 32-bit platform #1050

Closed
Aloxaf opened this issue Mar 21, 2023 · 1 comment · Fixed by #1051
Closed

Number of permits exceeds limit on 32-bit platform #1050

Aloxaf opened this issue Mar 21, 2023 · 1 comment · Fixed by #1051

Comments

@Aloxaf
Copy link

Aloxaf commented Mar 21, 2023

jsonrpsee/core/src/server/rpc_module.rs

Line 469 in 014f771

let bounded_subs = BoundedSubscriptions::new(u32::MAX);

According to tokio's docs. Semaphore::MAX_PERMITS is usize::MAX >> 3. u32::MAX will cause panic on 32-bit platform.
@niklasad1
Copy link
Member

Yes, nice catch it will be fixed once #1034 is merged.

@niklasad1 niklasad1 mentioned this issue Mar 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove needless Semaphore::(u32::MAX) paritytech/jsonrpsee
2 participants
@niklasad1 @Aloxaf