Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename HttpMiddleware/WsMiddleware to avoid confusion #843

Closed
jsdw opened this issue Aug 3, 2022 · 0 comments · Fixed by #845
Closed

Rename HttpMiddleware/WsMiddleware to avoid confusion #843

jsdw opened this issue Aug 3, 2022 · 0 comments · Fixed by #845
Assignees

Comments

@jsdw
Copy link
Collaborator

jsdw commented Aug 3, 2022

"Middleware" is a term that has some certain meaning/connotations around being able to intercept and modify requests/responses. The things that we call middleware have no ability to effect the requests/responses and really just exist as hooks for metrics and logging purposes.

Let's call it something like RpcMetrics or what have you. This leaves the door open for "real" middleware, too, at some point in the future.

@jsdw jsdw added this to the v1.0 milestone Aug 3, 2022
@lexnv lexnv changed the title Rename HttpMissleware/WsMiddleware to avoid confusion Rename HttpMiddleware/WsMiddleware to avoid confusion Aug 3, 2022
@lexnv lexnv self-assigned this Aug 4, 2022
@lexnv lexnv closed this as completed in #845 Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants