Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp the include parameter #45

Closed
rzadp opened this issue Sep 7, 2023 · 0 comments · Fixed by #58
Closed

Revamp the include parameter #45

rzadp opened this issue Sep 7, 2023 · 0 comments · Fixed by #58

Comments

@rzadp
Copy link
Contributor

rzadp commented Sep 7, 2023

Currently, the include parameter is based on evaluating the glob in the shell, outside of the tool.
In the polkadot-sdk repo, if we run it for all of the sub-repos, we hit the limit of the length of arguments in a shell.

We should look into moving the evaluation into the tool, to avoid this problem.

In an illustrative example:
Change license-scanner ./**/*.rs into license-scanner './**/*.rs'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant