Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[parity-util-mem] remove cfg(target_arch) statements #416

Closed
ordian opened this issue Jul 29, 2020 · 0 comments
Closed

[parity-util-mem] remove cfg(target_arch) statements #416

ordian opened this issue Jul 29, 2020 · 0 comments

Comments

@ordian
Copy link
Member

ordian commented Jul 29, 2020

As mentioned in paritytech/substrate#6745, this is not future-proof and leads to runtime panics.

Instead, if there is no way to compute malloc_size_of, we should either make it a compile-time/link-time error, or change the API to return an Option<usize> instead of usize (although, this may be a substantial rewrite).

I don't have time to work on this today, but feel free to ask me any questions.

cc @expenses , @cheme

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant