This repository was archived by the owner on Nov 6, 2020. It is now read-only.
validate-chainspecs: check istanbul eips are in the foundation spec #11305
+14
−3
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -15,6 +15,15 @@ done | ||
| for spec in ethcore/res/ethereum/*.json; do | ||
| if ! ./target/release/chainspec "$spec"; then ERR=1; fi | ||
| done | ||
|
|
||
| echo "________Mainnet contains Istanbul EIPs________" | ||
| for eip in $(grep --only-matching "eip.*Transition" ethcore/res/ethereum/istanbul_test.json); do | ||
|
There was a problem hiding this comment. how to deal with There was a problem hiding this comment. Add them to the chain spec? There was a problem hiding this comment. yeah, I guess that is easiest solution even though they are redundant in this case. |
||
| if ! grep -q $eip ethcore/res/ethereum/foundation.json; then | ||
| echo "ERROR: $eip is missing in the foundation json spec" | ||
| ERR=1 | ||
| fi | ||
| done | ||
|
|
||
| #show sccache statistics | ||
| sccache --show-stats | ||
| exit $ERR | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't have to be addressed in this PR but would be good to run this on the other testing network (hard forks) such as Contantinople and so on.
In order to make sure that we are not breaking anything.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point, but I think since we're running tests with
istanbul_testspec, it should be caught there