Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Pause pruning during snapshotting #8738

Closed

Conversation

ordian
Copy link
Collaborator

@ordian ordian commented May 30, 2018

Fixes #7863.

@parity-cla-bot
Copy link

It looks like @ordian signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

@ordian ordian added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. labels May 30, 2018
@rphmeier
Copy link
Contributor

I think the problem isn't that simple, because we'll end up accumulating a ton of pending state data in memory while we aren't pruning.

@ordian
Copy link
Collaborator Author

ordian commented May 30, 2018

@rphmeier How about tracking the earliest state era needed for taking a snapshot?

@rphmeier
Copy link
Contributor

can you elaborate? I don't understand what you mean exactly

@ordian
Copy link
Collaborator Author

ordian commented May 31, 2018

ordian> I was thinking we can track and constantly update the minimal block number needed to produce the current state chunk. Or we can't do that?
rphmeier> in general it will always be the same block
rphmeier> otherwise we would have to add a ton of metadata to each trie node saying the block number it was last modified
rphmeier> that would be possible if we had an actual "trie" DB which is specialized for storing the state trie

@ordian ordian closed this May 31, 2018
@5chdn 5chdn added this to the 1.12 milestone May 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants