Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

update snappy #9082

Merged
merged 1 commit into from
Jul 13, 2018
Merged

update snappy #9082

merged 1 commit into from
Jul 13, 2018

Conversation

debris
Copy link
Collaborator

@debris debris commented Jul 10, 2018

contains: paritytech/rust-snappy#4

unrelated changes for rand crate are caused by bug in cargo: rust-lang/cargo#5702

cc @andresilva

may require cmake to be in the PATH

paritytech/rust-snappy#4 (review)

@debris debris added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. labels Jul 10, 2018
@andresilva
Copy link
Contributor

Yeah, was going to mention the cmake requirement. We should update the README to add it to the build dependencies and also other documentation on the wiki. We may also need to update some Dockerfiles. cc @5chdn @Tbaut.

@5chdn 5chdn added this to the 2.0 milestone Jul 10, 2018
@5chdn 5chdn mentioned this pull request Jul 10, 2018
@5chdn 5chdn added the A1-onice 🌨 Pull request is reviewed well, but should not yet be merged. label Jul 10, 2018
@5chdn 5chdn modified the milestones: 2.0, 2.1 Jul 10, 2018
@5chdn 5chdn removed the A1-onice 🌨 Pull request is reviewed well, but should not yet be merged. label Jul 11, 2018
@5chdn 5chdn added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jul 13, 2018
@ascjones ascjones merged commit 441cb79 into master Jul 13, 2018
@ascjones ascjones deleted the update_snappy branch July 13, 2018 10:25
@holiman holiman mentioned this pull request Jul 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants