Update README.md #9084

5chdn · 2018-07-10T09:27:27Z

update depencies (cmake) ref update snappy #9082
update rust version
encourage final feature
change parity to parity ethereum

dvdplm · 2018-07-10T09:37:31Z

README.md


-## [» Download the latest release «](https://github.com/paritytech/parity/releases/latest)
+### [» Download the latest release «](https://github.com/paritytech/parity/releases/latest)


Don't we need to update this link as well to https://github.com/paritytech/parity-ethereum/releases/latest?

We are not there yet :)

curl -I https://github.com/paritytech/parity-ethereum/releases/latest HTTP/1.1 404 Not Found

dvdplm · 2018-07-10T09:39:29Z

README.md


-From Parity Ethereum client version 1.10.0, the User Interface (UI) is accessible in a separate application called Parity UI. To keep using the UI in the browser (deprecated), [follow these steps](https://wiki.parity.io/FAQ-Basic-Operations,-Configuration,-and-Synchronization#the-parity-ui-application-isnt-working-the-way-i-want).
+From Parity-Ethereum client version 1.10.0, the User Interface (UI) is accessible in a separate application called Parity-UI. To keep using the UI in the browser (deprecated), [follow these steps](https://wiki.parity.io/FAQ-Basic-Operations,-Configuration,-and-Synchronization#the-parity-ui-application-isnt-working-the-way-i-want).


I'd change this to "The UI for Parity-Ethereum is available in a separate application called … …" – not sure why anyone reading this would care about when the UI was extracted?

dvdplm · 2018-07-10T09:41:12Z

README.md


-By default, Parity will also run a JSONRPC server on `127.0.0.1:8545` and a websockets server on `127.0.0.1:8546`. This is fully configurable and supports a number of APIs.
+By default, Parity-Ethereum will also run a JSONRPC server on `127.0.0.1:8545` and a websockets server on `127.0.0.1:8546`. This is fully configurable and supports a number of APIs.


I'd remove the "also": up to this point in the text we haven't really stated what services we start.

s/websockets server/websocket server/

To be consistent with the --help: "JSON-RPC HTTP" and "Web Sockets" :)

dvdplm · 2018-07-10T09:42:23Z

README.md


-If you run into an issue while using Parity, feel free to file one in this repository or hop on our [Gitter](https://gitter.im/paritytech/parity) or [Riot](https://riot.im/app/#/group/+parity:matrix.parity.io) chat room to ask a question. We are glad to help! **For security-critical issues**, please refer to the security policy outlined in [SECURITY.MD](SECURITY.md).
+If you run into an issue while using Parity-Ethereum, feel free to file one in this repository or hop on our [Gitter](https://gitter.im/paritytech/parity) or [Riot](https://riot.im/app/#/group/+parity:matrix.parity.io) chat room to ask a question. We are glad to help! **For security-critical issues**, please refer to the security policy outlined in [SECURITY.MD](SECURITY.md).


s/run into an issue/run into problems/ and then s/, feel free to file one/, feel free to file an issue in…/

dvdplm · 2018-07-10T09:44:34Z

README.md

  ```bash
-	$ rustup default stable-x86_64-pc-windows-msvc
+  $ rustup default stable-x86_64-pc-windows-msvc
  ```

 Once you have rustup installed, then you need to install:
 * [Perl](https://www.perl.org)
 * [Yasm](http://yasm.tortall.net)


Is this true? I have not run into any assembly code in the code base, perhaps this is stale info?

I have no clue about building on Windows.

ring required perl and ASM to generate build some crypto-modules written in perl/ASM. So I think it is still true if nothing has changed in our fork of ring

I see, thanks.

Tbaut · 2018-07-10T13:53:13Z

README.md


-From Parity Ethereum client version 1.10.0, the User Interface (UI) is accessible in a separate application called Parity UI. To keep using the UI in the browser (deprecated), [follow these steps](https://wiki.parity.io/FAQ-Basic-Operations,-Configuration,-and-Synchronization#the-parity-ui-application-isnt-working-the-way-i-want).
+By default, Parity-Ethereum will run a JSONRPC server on `127.0.0.1:8545` and a Web-Sockets server on `127.0.0.1:8546`. This is fully configurable and supports a number of APIs.


"JSON-RPC HTTP server" :)

Tbaut

LGTM with minor grumble 👍

stale

dvdplm

lgtm

Tbaut · 2018-07-12T12:44:24Z

Shouldn't we add some basic explanations on how to DL and launch a binary?

5chdn · 2018-07-12T16:55:09Z

This readme clearly needs some love. If you have time, happy to review a new revision. Also, it should have a prominent link to the wiki.

Update README.md

9a1ab51

5chdn added A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). M3-docs 📑 Documentation. labels Jul 10, 2018

5chdn added this to the 2.0 milestone Jul 10, 2018

5chdn requested a review from Tbaut July 10, 2018 09:27

rename parity client

34e2615

dvdplm previously requested changes Jul 10, 2018

View reviewed changes

docs: remove UI stuff from readme.

8e94f8b

5chdn added the A1-onice 🌨 Pull request is reviewed well, but should not yet be merged. label Jul 10, 2018

5chdn modified the milestones: 2.0, 2.1 Jul 10, 2018

Tbaut reviewed Jul 10, 2018

View reviewed changes

Tbaut approved these changes Jul 10, 2018

View reviewed changes

5chdn added A8-looksgood 🦄 Pull request is reviewed well. A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging. and removed A1-onice 🌨 Pull request is reviewed well, but should not yet be merged. labels Jul 11, 2018

docs: add changelog link to readme

f788d34

5chdn removed the A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging. label Jul 12, 2018

dvdplm approved these changes Jul 12, 2018

View reviewed changes

5chdn merged commit bab85dd into master Jul 12, 2018

5chdn deleted the a5-docs-readme branch July 12, 2018 16:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update README.md #9084

Update README.md #9084

5chdn commented Jul 10, 2018

dvdplm Jul 10, 2018

5chdn Jul 10, 2018

dvdplm Jul 10, 2018

dvdplm Jul 10, 2018

Tbaut Jul 10, 2018

dvdplm Jul 10, 2018

dvdplm Jul 10, 2018

5chdn Jul 10, 2018

niklasad1 Jul 11, 2018

dvdplm Jul 11, 2018

Tbaut Jul 10, 2018

Tbaut left a comment

dvdplm left a comment

Tbaut commented Jul 12, 2018

5chdn commented Jul 12, 2018


		## [» Download the latest release «](https://github.com/paritytech/parity/releases/latest)
		### [» Download the latest release «](https://github.com/paritytech/parity/releases/latest)


		From Parity Ethereum client version 1.10.0, the User Interface (UI) is accessible in a separate application called Parity UI. To keep using the UI in the browser (deprecated), [follow these steps](https://wiki.parity.io/FAQ-Basic-Operations,-Configuration,-and-Synchronization#the-parity-ui-application-isnt-working-the-way-i-want).
		From Parity-Ethereum client version 1.10.0, the User Interface (UI) is accessible in a separate application called Parity-UI. To keep using the UI in the browser (deprecated), [follow these steps](https://wiki.parity.io/FAQ-Basic-Operations,-Configuration,-and-Synchronization#the-parity-ui-application-isnt-working-the-way-i-want).


		By default, Parity will also run a JSONRPC server on `127.0.0.1:8545` and a websockets server on `127.0.0.1:8546`. This is fully configurable and supports a number of APIs.
		By default, Parity-Ethereum will also run a JSONRPC server on `127.0.0.1:8545` and a websockets server on `127.0.0.1:8546`. This is fully configurable and supports a number of APIs.


		If you run into an issue while using Parity, feel free to file one in this repository or hop on our [Gitter](https://gitter.im/paritytech/parity) or [Riot](https://riot.im/app/#/group/+parity:matrix.parity.io) chat room to ask a question. We are glad to help! For security-critical issues, please refer to the security policy outlined in [SECURITY.MD](SECURITY.md).
		If you run into an issue while using Parity-Ethereum, feel free to file one in this repository or hop on our [Gitter](https://gitter.im/paritytech/parity) or [Riot](https://riot.im/app/#/group/+parity:matrix.parity.io) chat room to ask a question. We are glad to help! For security-critical issues, please refer to the security policy outlined in [SECURITY.MD](SECURITY.md).


		From Parity Ethereum client version 1.10.0, the User Interface (UI) is accessible in a separate application called Parity UI. To keep using the UI in the browser (deprecated), [follow these steps](https://wiki.parity.io/FAQ-Basic-Operations,-Configuration,-and-Synchronization#the-parity-ui-application-isnt-working-the-way-i-want).
		By default, Parity-Ethereum will run a JSONRPC server on `127.0.0.1:8545` and a Web-Sockets server on `127.0.0.1:8546`. This is fully configurable and supports a number of APIs.

Update README.md #9084

Update README.md #9084

Conversation

5chdn commented Jul 10, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Tbaut left a comment

Choose a reason for hiding this comment

dvdplm left a comment

Choose a reason for hiding this comment

Tbaut commented Jul 12, 2018

5chdn commented Jul 12, 2018