Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

[light/net/load_timer] Replace Duration::new() with Duration::from_nanos #9387

Merged
merged 1 commit into from
Aug 21, 2018
Merged

[light/net/load_timer] Replace Duration::new() with Duration::from_nanos #9387

merged 1 commit into from
Aug 21, 2018

Conversation

niklasad1
Copy link
Collaborator

Replaces:

  • Duration::new() with Duration::from_nanos
  • explicit clone call with deref (to make it clear that copy is not an expensive operation here)

@niklasad1 niklasad1 added A0-pleasereview 🤓 Pull request needs code review. A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). M4-core ⛓ Core client code / Rust. labels Aug 21, 2018
@ordian ordian added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Aug 21, 2018
@cheme cheme self-requested a review August 21, 2018 14:54
@ascjones ascjones merged commit e12a26d into master Aug 21, 2018
@ascjones ascjones deleted the light/load_timer_use_duration_from_nanos branch August 21, 2018 15:01
@5chdn 5chdn added this to the 2.1 milestone Aug 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ascjones ascjones ascjones approved these changes

@cheme cheme cheme approved these changes

@ordian ordian ordian approved these changes

Assignees
No one assigned
Labels
A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Milestone
2.1 Whatever
Development

Successfully merging this pull request may close these issues.
5 participants
@niklasad1 @ascjones @cheme @ordian @5chdn